Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RMT::Mirror #192

Merged
merged 4 commits into from Jun 14, 2018
Merged

Refactor RMT::Mirror #192

merged 4 commits into from Jun 14, 2018

Conversation

ikapelyukhin
Copy link
Contributor

@ikapelyukhin ikapelyukhin commented Jun 11, 2018 •
edited

Fixes #189. Partially addresses #87.

@suse-tests-pass
Copy link
Collaborator

suse-tests-pass commented Jun 11, 2018 •
edited

1 Warning
⚠️ Unless this is a trivial change, please include a CHANGELOG entry.
Run osc vc in the package directory to add one.

Generated by 🚫 Danger

thutterer
thutterer approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@thutterer thutterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! So much nicer 👍

@thutterer thutterer merged commit 3fb3063 into log_version Jun 14, 2018
@thutterer thutterer deleted the rmt_mirror_refactoring branch June 14, 2018 14:48
@ikapelyukhin ikapelyukhin mentioned this pull request Jun 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thutterer thutterer thutterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikapelyukhin @suse-tests-pass @thutterer