-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deregister after integration tests #217
Conversation
Generated by 🚫 Danger |
docker-compose-test.yml
Outdated
@@ -20,6 +20,7 @@ services: | |||
|
|||
rmt_test: | |||
privileged: true | |||
network_mode: bridge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed because had network issues locally inside of docker container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are de-registering only a system.
I haven't looked over the full test suite but I'm guessing this is a system you register against that test-RMT earlier? Then this would not be required, since you wipe out the full RMT including its database, right?
What is required instead and what I meant in the review meeting is that you have to make sure to remove any traces from that test-RMT itself from SCC.
Since you create these test-RMTs from scratch each time, they have a new uuid each time, then hit the SCC API which leads to new proxies in the SCC database. Just have a look at https://scc.suse.com/proxies?current_organization=70 😉
Do those tests even register the system in SCC at all? |
668bac0
to
e626d30
Compare
@ikapelyukhin I register RMT host system in order to install packages |
e626d30
to
9853043
Compare
During which phase? If the system is being registered during |
@ikapelyukhin I do deregister it in |
By "right after" I mean in |
85c5189
to
f8eb72e
Compare
f8eb72e
to
cfc0cb8
Compare
No description provided.