Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister after integration tests #217

Merged
merged 4 commits into from
Sep 3, 2018

Conversation

Sergeykot
Copy link
Contributor

No description provided.

@suse-tests-pass
Copy link
Collaborator

1 Warning
⚠️ Unless this is a trivial change, please include a CHANGELOG entry.
Run osc vc in the package directory to add one.

Generated by 🚫 Danger

@@ -20,6 +20,7 @@ services:

rmt_test:
privileged: true
network_mode: bridge
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed because had network issues locally inside of docker container

Copy link
Contributor

@thutterer thutterer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are de-registering only a system.
I haven't looked over the full test suite but I'm guessing this is a system you register against that test-RMT earlier? Then this would not be required, since you wipe out the full RMT including its database, right?

What is required instead and what I meant in the review meeting is that you have to make sure to remove any traces from that test-RMT itself from SCC.

Since you create these test-RMTs from scratch each time, they have a new uuid each time, then hit the SCC API which leads to new proxies in the SCC database. Just have a look at https://scc.suse.com/proxies?current_organization=70 😉

@ikapelyukhin
Copy link
Contributor

Do those tests even register the system in SCC at all?

@Sergeykot Sergeykot force-pushed the deregister-after-integration-tests branch from 668bac0 to e626d30 Compare August 30, 2018 17:00
@Sergeykot
Copy link
Contributor Author

@ikapelyukhin I register RMT host system in order to install packages
@thutterer the system I deregister is the one RMT installed on. I also added now setting the system UUID so that it will be always the same

@Sergeykot Sergeykot force-pushed the deregister-after-integration-tests branch from e626d30 to 9853043 Compare August 30, 2018 17:08
@ikapelyukhin
Copy link
Contributor

ikapelyukhin commented Aug 30, 2018

During which phase? If the system is being registered during docker build phase, it would be better to deregister right after.

@Sergeykot
Copy link
Contributor Author

@ikapelyukhin I do deregister it in post stage of Jenkinsfile. Isn't that "right after" ?

@ikapelyukhin
Copy link
Contributor

By "right after" I mean in docker build. The container doesn't need to be registered to run the tests, and it would prevent potential issues with caching or Jenkins not executing the post stage of the pipeline for some reason.

@Sergeykot Sergeykot force-pushed the deregister-after-integration-tests branch 2 times, most recently from 85c5189 to f8eb72e Compare August 31, 2018 12:41
@Sergeykot Sergeykot force-pushed the deregister-after-integration-tests branch from f8eb72e to cfc0cb8 Compare August 31, 2018 12:44
@Sergeykot Sergeykot merged commit 3928a21 into master Sep 3, 2018
@Sergeykot Sergeykot deleted the deregister-after-integration-tests branch September 3, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants