Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup spec file and remove ssl directory from git root #219

Merged
merged 1 commit into from Sep 10, 2018
Merged

Cleanup spec file and remove ssl directory from git root #219

merged 1 commit into from Sep 10, 2018

Conversation

felixsch
Copy link
Contributor

No description provided.

@suse-tests-pass
Copy link
Collaborator

1 Warning
⚠️ Unless this is a trivial change, please include a CHANGELOG entry.
Run osc vc in the package directory to add one.

Generated by 🚫 Danger

ikapelyukhin
ikapelyukhin reviewed Aug 30, 2018
View reviewed changes
package/rmt-server.spec Outdated
echo "RMT ssl configuration has been moved to a new place. New place is: %{conf_dir}/ssl"
if [ -d %{app_dir}ssl ]; then
mv %{app_dir}ssl/* %{conf_dir}ssl
echo "RMT ssl configuration has been moved to a new place: %{conf_dir}/ssl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sergeykot
Copy link
Contributor

screenshot_20180831_173649
FYI when I install RMT now on version 1.0.0 which has no generated SSL certs I get this output

@Sergeykot
Copy link
Contributor

FYI (maybe will help to debug): before this PR the output was this one:
screenshot_20180831_173728

Sergeykot
Sergeykot requested changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@Sergeykot Sergeykot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still get misleading output while upgrading from version 1.0.0 and having no SSL certficates generated. See comments with screenshots,

@felixsch
Copy link
Contributor Author

felixsch commented Sep 4, 2018 •
edited

@Sergeykot @ikapelyukhin The problem is that all installations moved the ssl directory from the git repository which has the .keep file. That's why it's moving even if there are no ssl certificates generated yet. I can check for rmt-ca.crt to make sure that the certificates exist and leave behind a stale directory in case it's not. What do you think?

@ikapelyukhin
Copy link
Contributor

@felixsch Sure, checking that some cert file exists should do it.

@Sergeykot
Copy link
Contributor

@felixsch yes, I think that should be fine.

@Sergeykot
Copy link
Contributor

works for me both for the case with and without SSL certs
LGTM 👍

@Sergeykot
Copy link
Contributor

feel free to update branch from master and merge

@felixsch felixsch merged commit a05c523 into master Sep 10, 2018
@ikapelyukhin ikapelyukhin deleted the cleanup-package branch September 10, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikapelyukhin ikapelyukhin ikapelyukhin left review comments

@Sergeykot Sergeykot Sergeykot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixsch @suse-tests-pass @Sergeykot @ikapelyukhin