Skip to content

Commit

Permalink
fmt fix and slight makefile changes to never miss fmt again
Browse files Browse the repository at this point in the history
  • Loading branch information
stefanotorresi committed Apr 7, 2020
1 parent 1a00e72 commit f48f0a0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
script: make static-checks
- stage: Test
name: Unit tests
script: make test
script: make gotest
- stage: Release
name: Build and upload binaries on GitHub
if: tag IS present
Expand Down
6 changes: 4 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ REPOSITORY ?= SUSE/sap_host_exporter
# the Go archs we crosscompile to
ARCHS ?= amd64 arm64 ppc64le s390x

default: clean download mod-tidy generate fmt vet-check test build
default: clean download mod-tidy generate fmt test build

download:
go mod download
Expand Down Expand Up @@ -47,9 +47,11 @@ fmt-check:
generate:
go generate ./...

test: download
gotest:
go test -v ./...

test: download static-checks gotest

coverage:
@mkdir build
go test -cover -coverprofile=build/coverage ./...
Expand Down
1 change: 0 additions & 1 deletion collector/default_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ func RecordConcurrently(recorders []func(ch chan<- prometheus.Metric) error, ch
close(results)
}()


// Scroll the results channel and store potential errors in an array. This will block until the channel is closed.
for err := range results {
if err != nil {
Expand Down

0 comments on commit f48f0a0

Please sign in to comment.