Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: common labels for instance data #40

Merged
merged 8 commits into from
Apr 17, 2020
Merged

Feature: common labels for instance data #40

merged 8 commits into from
Apr 17, 2020

Conversation

stefanotorresi
Copy link
Collaborator

This PR implements a custom, memoized, method on the WebService interface, that pulls instances properties and stores them locally, to then be used by all the collectors to add common labels SID, instance_name, instance_number and instance_hostname.
It also remove sap_start_service_instances metric duplication.

MalloZup
MalloZup approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx looks good only minor comments

@MalloZup MalloZup merged commit 9e21268 into SUSE:master Apr 17, 2020
@stefanotorresi stefanotorresi deleted the feature/common-instance-data branch June 26, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalloZup MalloZup MalloZup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanotorresi @MalloZup