introduce the start service collector #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloZup
reviewed
Mar 5, 2020
MalloZup
reviewed
Mar 5, 2020
MalloZup
reviewed
Mar 5, 2020
|
looks good |
|
@stefanotorresi also we should state in the documentation how we generate the things etc, but this is for the final review of the pr, sofar I think is good! |
|
thanks for the feedback, @MalloZup! good round! I will get at it immediately and ping you once this is ready. |
stefanotorresi
force-pushed
the
feature/start-service-collector
branch
from
dbcbd14
to
1151d3a
Compare
MalloZup
reviewed
Mar 5, 2020
README.md
Outdated
| $ ./sap_host_exporter | ||
| INFO[0000] Serving metrics on 0.0.0.0:9680 | ||
| ```shell | ||
| ./sap_host_exporter --sap-control-url http://foobarbaz:50013 |
There was a problem hiding this comment.
can we have here like ```./sap_host_exporter --sap-control-url http://SAP_INSTANCE_URL_AND_NUMBER:50013````
There was a problem hiding this comment.
SAP_URL = 'http://host:port?wsdl'
There was a problem hiding this comment.
hmm yeah I'll make it more explanatory
MalloZup
reviewed
Mar 5, 2020
MalloZup
reviewed
Mar 5, 2020
MalloZup
reviewed
Mar 5, 2020
|
@MalloZup can I merge this? |
MalloZup
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a working draft. If it looks good for you, I will proceed with writing some tests for it.