This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
Realigning our role composition back with cf upstream #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
force-pushed
the
llqBKY7z-realigning-our-role-composition-back-with-cf-upstream
branch
4 times, most recently
from
c966261
to
07f464d
Compare
They are not being used for anything anymore. [trello#llqBKY7z]
jandubois
force-pushed
the
llqBKY7z-realigning-our-role-composition-back-with-cf-upstream
branch
from
07f464d
to
5fff366
Compare
[trello#llqBKY7z]
[trello#llqBKY7z]
The old loggregator role was already claiming port 8082 for "grpc", so would potentially conflict with syslog-rlp. However, I think 8082 is the doppler grpc port, which doesn't run on the loggregator role, so this looks like a mistake. [trello#llqBKY7z]
Also move cc_uploader role (from cc-uploader) and file_server role (from diego_access) into api role as well. Open issues/questions: * api needs to talk to routing-api. Since we don't require hairpin support (Azure doesn't support it yet), we cannot use the service name, but need to access it via 127.0.0.1. This means that the routing-api cert also needs to list the loopback address as an alternate name. * routing-api was an active-passive role, so api is also active-passive now, which will affect scalability. [trello#llqBKY7z]
Includes (what is still left of) cc-clock, cc-uploader (tps), diego-access, diego-brain, and syslog-scheduler. Open issues/questions: * syslog-scheduler was a headless role; that tag is now lost. * cc-clock and syslog-scheduler were singletons; they can now have up to 3 instances (and will have 2 by default under HA). [trello#llqBKY7z]
Open issue/question: * Upstream rename just the blobstore role, but not the URL, so that the singleton role can be replaced with a scalable HA version via ops files, without having to also update any of the other roles as well. [trello#llqBKY7z]
jandubois
force-pushed
the
llqBKY7z-realigning-our-role-composition-back-with-cf-upstream
branch
from
5fff366
to
59d3345
Compare
mook-as
suggested changes
Jul 20, 2018
3 tasks
|
jandubois
deleted the
llqBKY7z-realigning-our-role-composition-back-with-cf-upstream
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been replaced by #1647 and can be deleted once we are sure I didn't make any mistakes during the rebasing and cherry-picking... 😄