Added Stratos to Vagrant #1973
Merged
Added Stratos to Vagrant #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mook-as
requested changes
Jan 10, 2019
mook-as
reviewed
Jan 11, 2019
f0rmiga
force-pushed
the
add-stratos-vagrant
branch
from
66f1ebb
to
da93afe
Compare
|
Tested this from a Vagrant VM. LGTM |
satadruroy
dismissed
mook-as’s stale review
Ran Vagrant VM with expected results.
satadruroy
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test plan
make/stratos/runto deploy it inside a Vagrant machine.make/stratos/stopto remove the Helm installation as well as the namespace.make runto check the entire deployment as Stratos is the last piece to be deployed, and first to be removed frommake stop.https://cf-dev.io:8443on the browser.admin:changeme.