feature: mixed disk drive layouts #653
Open
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ildefons
force-pushed
the
652-mixed-drive-layout
branch
from
aab3b4e
to
0849408
Compare
m-ildefons
force-pushed
the
652-mixed-drive-layout
branch
from
0849408
to
b295a3c
Compare
|
This looks like a new feature, and a slight behavior change. Did we have any discussion on why do we need this? If so, is there any reference to the discussion and decision taken? |
kshtsk
reviewed
Jul 12, 2022
seslib/deployment.py
Outdated
| def __append_disks_to_node(self, node): | ||
| for _i, _n in enumerate(self.settings.num_disks): | ||
| for _ in range(_n): | ||
| node.storage_disks.append(Disk(self.settings.disk_size[_i] |
There was a problem hiding this comment.
What happens disk_size length is less than num_disks?
There was a problem hiding this comment.
I wasn't aware that the foo[bar] or buzz syntax doesn't work with lists. AFAIK it works with dicts though. Fixed it.
kshtsk
suggested changes
Jul 12, 2022
|
jenkins retest this please |
m-ildefons
force-pushed
the
652-mixed-drive-layout
branch
from
b295a3c
to
fed323a
Compare
Provision mixed disk drive layouts when specifying `--num-disks` and `--disk-size` multiple times. fixes: SUSE#652 Signed-off-by: Moritz Röhrich <moritz.rohrich@suse.com>
m-ildefons
force-pushed
the
652-mixed-drive-layout
branch
from
fed323a
to
85de9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provision mixed disk drive layouts when specifying
--num-disksand--disk-sizemultiple times.fixes: #652
Signed-off-by: Moritz Röhrich moritz.rohrich@suse.com