Replace ExAPI.json with extapi.c (extapi.c explaination wiki: https://github.com/SVF-tools/SVF/wiki/Handling-External-APIs-with-extapi.c) #1165
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1165 +/- ##
==========================================
+ Coverage 64.64% 64.74% +0.10%
==========================================
Files 223 222 -1
Lines 23865 23475 -390
==========================================
- Hits 15427 15200 -227
+ Misses 8438 8275 -163
|
svf-llvm/lib/LLVMModule.cpp
Outdated
| /// if this function is declaration | ||
| candidateDecls.insert(&func); | ||
| removedFuncList.push_back(&func); | ||
| continue; |
| @@ -827,6 +830,64 @@ void LLVMModuleSet::buildFunToFunMap() | |||
| decls.push_back(decl); | |||
| } | |||
| } | |||
|
|
|||
| /// App Func decl -> SVF extern Func def | |||
There was a problem hiding this comment.
rewrite the comments to state the three cases.
svf-llvm/lib/LLVMModule.cpp
Outdated
| for (const Function* extfun : extFuncs) | ||
| { | ||
| std::string declName = fdecl->getName().str(); | ||
| // Change function like llvm.memcpy.p0i8.p0i8.i64 to llvm_memcpy_p0i8_p0i8_i64 |
| } | ||
|
|
||
| /// Overwrite | ||
| /// App Func def -> SVF extern Func def |
There was a problem hiding this comment.
put the table as comments here.
|
extapi.c/ExtAPI.json: SVF with extapi.c:
|
svf-llvm/lib/LLVMModule.cpp
Outdated
| if (func.isDeclaration()) | ||
| /// Remove unused function in extapi.bc module | ||
| /// if this function func defined in extapi.bc but never used in application code (without any corresponding declared functions). | ||
| if (mod.getName().str() == Options::ExtAPIInput() && func.getName().str() != "svf__main" && FunDefToDeclsMap.find(&func) == FunDefToDeclsMap.end() |
There was a problem hiding this comment.
put this condition in a new method.
svf-llvm/lib/LLVMModule.cpp
Outdated
| @@ -827,6 +830,94 @@ void LLVMModuleSet::buildFunToFunMap() | |||
| decls.push_back(decl); | |||
| } | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
put these comments before the function.
Fix AppDef -> ExtDef/ExtDef -> AppDef (overwrite).
Give each case an example.
shuangxiangkan
changed the title
No description provided.