Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export file in Chrome doesn't work #282

Closed
adrianbj opened this issue Sep 13, 2018 · 5 comments
Closed

Export file in Chrome doesn't work #282

adrianbj opened this issue Sep 13, 2018 · 5 comments
Labels

Comments

@adrianbj
Copy link
Contributor

Describe the bug
If you use the Export option, Chrome opens a tab to show the PNG version, but then instantly closes it again.

To Reproduce
Steps to reproduce the behavior:

  1. Go to SVG-Edit > Export > OK

Expected behavior
The tab should stay open so the image can be downloaded

SVG-Edit environment (IMPORTANT)
File for SVG-Edit: svg-editor.html
Version: 3.x (testing on github demo)
Protocol: https

Desktop (please complete the following information):
OS: MacOS High Sierra
Browser: Chrome
Version: 69.0.3497.81

@brettz9
Copy link
Contributor

brettz9 commented Sep 13, 2018

Thanks for the report! Fixed now in master...

@adrianbj
Copy link
Contributor Author

I am testing master (I think) via: https://rawgit.com/SVG-Edit/svgedit/master/editor/svg-editor.html

and even with Chrome allowing popups, it's still not working.

Maybe you haven't compiled a new master version, so maybe that's why I am not seeing the fix?

@brettz9
Copy link
Contributor

brettz9 commented Sep 13, 2018

Hmmm....It's working for me there too even without the update of files...

I have updated the compiled files now though, so you might try again... If you're still seeing issues, can you paste the data you're trying to export? Also any console errors...

@adrianbj
Copy link
Contributor Author

Ok, looks like it was AdBlockPlus that was blocking the popup - it seems to work ok without it. I expect it will catch others out as well though.

@brettz9
Copy link
Contributor

brettz9 commented Sep 13, 2018

I think it is more convenient to have exports continue to open in new tabs than to force downloads, so I've added an item about blockers to the FAQ...

By the way, thanks very much for your vigorous and detailed reporting of issues--it is also nice having someone with some familiarity with the old code...

@brettz9 brettz9 added the bug label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants