Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 7 Cocoapods release #215

Closed
KrauseFx opened this issue Oct 29, 2013 · 5 comments
Closed

iOS 7 Cocoapods release #215

KrauseFx opened this issue Oct 29, 2013 · 5 comments

Comments

@KrauseFx
Copy link

My library has a dependency to SVProgressHUD. Unfortunately podspec files can not have dependencies to a specific commit or branch, but only to a version number.
Could you release a version for iOS 7?

@samvermette
Copy link
Contributor

When I do pod push master I get:

Validating spec
-> SVProgressHUD (1.0)
- ERROR | [xcodebuild] SVProgressHUD/SVProgressHUD/SVProgressHUD.m:420:24: error: the current deployment target does not support automated __weak references

[!] The SVProgressHUD.podspec specification does not validate.

I've had my share of frustrations with CocoaPods in the past and do not have the time to debug this. Did a quick Google search and tried a few things, but no luck. Any ideas?

@KrauseFx
Copy link
Author

Just a guess here:
Have you tried changing SVProgressHUD.m:420 to

__typeof (&*self) __weak weakSelf = self;

It's the only __weak in your code

@ehuynh
Copy link
Contributor

ehuynh commented Oct 30, 2013

i don't see why you need a weak reference there. It shouldn't create a retain cycle if you just use self. In this case self does not own the animation block. Agree?

@KrauseFx
Copy link
Author

Oh, that's actually right. Inside an animation block it's fine to just use self.

samvermette added a commit that referenced this issue Oct 31, 2013
@KrauseFx
Copy link
Author

KrauseFx commented Nov 1, 2013

@samvermette Great, thanks a lot for the release! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants