Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No supported interface orientation in real time #490

Closed
zarochintsev opened this issue Sep 30, 2015 · 5 comments
Closed

No supported interface orientation in real time #490

zarochintsev opened this issue Sep 30, 2015 · 5 comments

Comments

@zarochintsev
Copy link

No supported interface orientation in real time. It was seen on iOS 9.1 Public beta.

If progress hud is visible and flip the device, the background will be in the same position.

@zarochintsev
Copy link
Author

image

@estebansotoara
Copy link
Contributor

Hi,
it is possible that there is an error in the validation in SVProgressHUD.m line 583? I changed it and it is updating the HUD properly when the orientation is changed but I currently can only test in an iPhone 5 so there is a chance that this solution could fail in other devices.

I made a fork with this solution (https://github.com/estebansotoara/SVProgressHUD/tree/support_interface_orientation), I can make a PR if it is needed.

@honkmaster
Copy link
Member

@davidolesch could you please check if this is a bug in line 583 as described?

@davidolesch
Copy link
Contributor

@honkmaster yes that's a bug in my code. @estebansotoara made the correct change here.

@estebansotoara
Copy link
Contributor

I created a pull request (#512), I'm glad it worked

honkmaster pushed a commit that referenced this issue Nov 12, 2015
…tion

Fixes #490. No supported interface orientation in real time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants