Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay bounds to mask events after window resize #646

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@banjun
Copy link

commented Jul 22, 2016

on 2.0.3 tag, the overlay is not autoresized while HUD is dismissed.

example steps to reproduce:

  1. setDefaultMaskType to .Black
  2. show and dismiss HUD in portrait screen
  3. make the device landscape while HUD is dismissed
  4. show HUD in landscape screen
  5. on right side of the window, user interactions are pass through to views below.

at step 5, the overlay.frame is still portrait because autoresizing is happened while the overlay is not in the window view hierarchy.

this is also reproducible on multitasking split view.

@honkmaster

This comment has been minimized.

Copy link
Member

commented Jul 31, 2016

Should be fixed on master.

@honkmaster honkmaster closed this Jul 31, 2016

@banjun

This comment has been minimized.

Copy link
Author

commented Aug 1, 2016

I have confirmed that this issue is resolved on master.
ce1b21f#diff-a9f291dcb26df32018013622ccd7783dR1250

But I wonder it is correct fix in terms of layout, the way resetting frame on every overlayView getter call.
As you still use _overlayView.autoresizingMask, I think manual resetting frame just before addSubview: overlayView is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.