Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : 랭킹 hotfix #87

Merged
merged 2 commits into from
Feb 2, 2023
Merged

fix : 랭킹 hotfix #87

merged 2 commits into from
Feb 2, 2023

Conversation

nowrobin
Copy link
Member

@nowrobin nowrobin commented Feb 1, 2023

추가한 기능 설명


check list

  • issue number를 브랜치 앞에 추가 하였는가?
  • 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했는가?

AlgeMoya
AlgeMoya approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@AlgeMoya AlgeMoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position이나 align 등 미세조정 문제였던거 같네요. 수정 감사합니다!

sangminlee98
sangminlee98 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@sangminlee98 sangminlee98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !

src/components/RankList/styles.module.scss Show resolved Hide resolved
@nowrobin nowrobin merged commit d49dc8e into develop Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlgeMoya AlgeMoya AlgeMoya approved these changes

@sangminlee98 sangminlee98 sangminlee98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nowrobin @AlgeMoya @sangminlee98