Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll lock to the body when the new markdown editor is in full-screen mode #204

Closed
vinutv opened this issue Feb 12, 2020 · 1 comment
Closed

Add scroll lock to the body when the new markdown editor is in full-screen mode #204

vinutv opened this issue Feb 12, 2020 · 1 comment
Labels
design Requires help from designers enhancement New feature or request

Comments

@vinutv
Copy link
Contributor

vinutv commented Feb 12, 2020

Screenshot 2020-02-12 at 3 58 06 PM
@vinutv vinutv added enhancement New feature or request design Requires help from designers labels Feb 12, 2020
@harigopal harigopal changed the title Add scroll lock to the container while an overlay active. Add scroll lock to the body when the new markdown editor is in full-screen mode Feb 13, 2020
@harigopal
Copy link
Member

harigopal commented Feb 13, 2020 •
edited
Loading

There are a few possible approaches possible for this. I think it might make sense to pass an optional container element to the editor, to which it'll apply the scroll lock class, with the container defaulting to the HTML body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Requires help from designers enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@harigopal @vinutv @irajsuhail