-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commonly requested commands (admin subcommands) #376
base: master
Are you sure you want to change the base?
Conversation
/admin setCount <integer> /admin messageTo <messageHandler> <timeToDelay (float)>
Fix for previous commit.
@@ -4457,6 +4489,10 @@ private static void showAdminCmdSyntax(obj_id self) throws InterruptedException | |||
sendConsoleMessage(self, "returns the account username of the specified player"); | |||
sendConsoleMessage(self, "\\#00ffff setWeather \\#bfff00 <clear | mild | heavy | severe> \\#."); | |||
sendConsoleMessage(self, "sets the weather for the current scene"); | |||
sendConsoleMessage(self, "\\#00ffff setCount \\#bfff00 <integer> \\#."); | |||
sendConsoleMessage(self, "sets the amount of a stackable item."); | |||
sendConsoleMessage(self, "\\#00ffff sendMessageTo \\#bfff00 <messageHandler> <time as float> \\#."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command is just “messageTo” but here it’s listed as “sendMessageTo”
float messageDelay; | ||
if(st.hasMoreTokens()) { | ||
message = st.nextToken(); | ||
messageDelay = utils.stringToFloat(st.nextToken()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With StringTokenizer you need to check hasMoreTokens() for each parameter. This currently has the potential to throw a null pointer exception because you’re calling nextToken() twice without knowing there are actually 2 more tokens (vs just 1 for the message param).
As an aside, these command scripts could really be cleaned up with a helper method and class used to validate params and return syntax because it’s so messy the way we currently do it over and over. A todo for another time.
count = 500; | ||
} | ||
setCount(target, count); | ||
sendConsoleMessage(self, "You have added " + count + " to " + target + " (" + getName(target) + ")"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why these are console messages when standard pattern is system messages for admin command results. Not a big deal but curious deviation.
/admin setCount
/admin messageTo <timeToDelay (float)>
.gitignore for default IntelliJ IDEA build copies.
Note: /admin messageTo does not take any params, as it just calls the handler. In the future I may add a SUI textbox window to enter the message and delay line by line and parse it. TBD.