Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCED: added unwrap() method and PlUnwrap() #59

Merged
merged 1 commit into from Nov 1, 2023
Merged

ENHANCED: added unwrap() method and PlUnwrap() #59

merged 1 commit into from Nov 1, 2023

Conversation

kamahen
Copy link
Contributor

@kamahen kamahen commented Oct 21, 2023

This gets around the problem reported here: https://swi-prolog.discourse.group/t/ann-swi-prolog-9-1-17/6890/10

@JanWielemaker
Copy link
Member

This pull request has been mentioned on SWI-Prolog. There might be relevant details there:

https://swi-prolog.discourse.group/t/ann-swi-prolog-9-1-17/6890/17

@kamahen kamahen force-pushed the unwrap branch 2 times, most recently from 6bea052 to 790c664 Compare October 22, 2023 03:24
@JanWielemaker
Copy link
Member

Can we add #define C_ unwrap() to maintain compatibility? I really dislike incompatible changes ...

@kamahen
Copy link
Contributor Author

kamahen commented Oct 22, 2023

I've added #define C_ unwrap().
Please don't merge yet; I want to look at adding Plx_get_name_arity() as discussed in a private email. (I may do it as a separate PR or a separate commit)

@kamahen
Copy link
Contributor Author

kamahen commented Oct 22, 2023

Ready for review and merge. (I'l deal with Plx_get_name_arity_ex() in a separate PR.

@kamahen
Copy link
Contributor Author

kamahen commented Oct 31, 2023

See Issue #60 -- I'll change SWI-cpp2.h to include SWI-cpp2.cpp (with some macros to allow separate compilation). I'll add to this PR if it hasn't been merged; otherwise I'll make a new PR.

@JanWielemaker JanWielemaker merged commit 6cba69b into SWI-Prolog:master Nov 1, 2023
@kamahen kamahen deleted the unwrap branch November 1, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamahen @JanWielemaker