Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_reply(stream) and http_reply(cgi_stream) transfer more data than specified #10

Open
triska opened this issue Jul 29, 2015 · 1 comment

Comments

@triska
Copy link
Member

triska commented Jul 29, 2015

In the final 2 clauses of http_reply_data/4, the goals of the form:

copy_stream(Out, In, Header, 0, end).

should read:

copy_stream(Out, In, Header, 0, Len).

so that only the intended content is actually transmitted.

@JanWielemaker
Copy link
Member

It is unclear to me. The last relevant was be200e2, which introduced byte-ranges for files. Before that, the last clauses accepted a length, but did send the
complete stream data. A quick search doesn't really tell me what this is used for and I've forgotten.

Surely, using Len is in general wrong as well, as the input (or output) stream might not be binary. I don't really know what to do with this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants