MNT/FIX: Update wrappers with proper argument order #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python side expects (date, lon, lat, z), which is what the Fortran subroutines is defined as, but the wrapper interface defintion had lon/z swapped (corresponding to the actual Fortran implementation). This doesn't affect any results when using run since the interface uses the argument order as inputs and they were all the same type. It does affect calling the pygtd7d/pymsiscalc routines directly with keyword arguments though as those weren't in the right order. Added a test to make sure the keyword arguments are working as expected now.
greglucas
force-pushed
the
fix-pyf-wrapper
branch
from
3342885
to
54b105e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python side expects
(date, lon, lat, z), which is what the Fortran subroutines is defined as, but the wrapper interface defintion hadlon/zswapped (corresponding to the actual Fortran implementation).This doesn't affect any results since the interface uses the argument order as inputs and they were all the same type and defined properly in the actual subroutine implementation.
closes #24