Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change .env logic and fix remaining funds #214

Merged
merged 8 commits into from
May 30, 2023
Merged

Conversation

HamdiBenK
Copy link
Contributor

@HamdiBenK HamdiBenK commented May 25, 2023

-Separate the .env file in 3 files '.env.local' '.env.testnet' & '.env.mainnet'
-getting rid of different variable for testnet & prod
-remove logic and if conditions in const.js & config.js
-remove mongoConnectoin sum and juste use mongo URL to connecto to the db
-fix bug in getReamining funds api
-add ".env.example"

@ksibisamir
Copy link
Contributor

Environment Variables: You have done an excellent job of managing sensitive information such as API keys, client secrets, and other configuration details by using environment variables. This is a critical practice for maintaining the security of your application. However, make sure to also have a .env.example file that outlines all the environment variables required by the application. This helps other developers understand what they need to provide to get the application running.

conf/config.js Outdated
@@ -2,7 +2,7 @@ const { auth } = require('google-auth-library')
const { Token } = require('graphql')
const { environment } = require('./settings')

exports.mongoConnection = () => {
/*exports.mongoConnection = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of Commented Code: I've noticed that a lot of code is currently commented out, particularly around the MongoDB connection configuration and contracts. If this code is no longer necessary, I would recommend removing it to improve readability. If parts of this code are still useful for future reference, I suggest moving it into a separate reference document or saving it in commit history.

Explanation for Commented Code: If some parts of the commented code are still relevant, it would be helpful to add comments explaining why they are commented out and under what circumstances they might be uncommented.

@ksibisamir ksibisamir merged commit 4466d2e into develop May 30, 2023
3 checks passed
@ksibisamir ksibisamir deleted the remove-callback branch May 30, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revision of .env files organization for better compliance with standards
4 participants