Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a Markdown table to comment hangs UI #788

Closed
goodger opened this issue May 20, 2021 · 1 comment
Closed

adding a Markdown table to comment hangs UI #788

goodger opened this issue May 20, 2021 · 1 comment
Assignees
Labels

Comments

@goodger
Copy link

goodger commented May 20, 2021

Steps to reproduce:

  1. In an open .sgf file, toggle edit mode with Ctrl-E.
  2. In the comments area paste in a Markdown table, e.g. the text below.
  3. Ctrl-E to toggle edit mode doesn't work: edit mode remains. The UI becomes unusable. After zooming the window to full-screen, the board remains at its original size. Clicking on the board produces the stone-click sound, but nothing is visible (no cursor, no new stones, nothing). Ctrl-N brings up a confirmation dialog as usual, but the UI isn't reset for the new file/record.
First Header | Second Header
------------ | -------------
Content from cell 1 | Content from cell 2
Content in the first column | Content in the second column

Expected behavior: Ideally the table should be rendered as a table by Markdown. As a failsafe, the text should be shown as text. This should not hang the UI.

My environment: Sabaki 0.51.1 on Ubuntu Linux 20.10

@apetresc apetresc added the bug label May 20, 2021
@apetresc apetresc self-assigned this Jul 5, 2021
@apetresc
Copy link
Member

apetresc commented Jul 5, 2021

Should be good now!

2021-07-04-21 58 28

Will be released in v0.52.0 soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants