Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build own docker image for raspberry pi #68

Merged
merged 6 commits into from Jun 5, 2020
Merged

Build own docker image for raspberry pi #68

merged 6 commits into from Jun 5, 2020

Conversation

ardinusawan
Copy link
Contributor

@ardinusawan ardinusawan commented Jun 1, 2020 •
edited

This PR to fix issue here

@ardinusawan ardinusawan mentioned this pull request Jun 1, 2020
Closed
@ardinusawan ardinusawan changed the title Build own docker image for rasperry pi Build own docker image for rasbperry pi Jun 1, 2020
@ardinusawan ardinusawan changed the title Build own docker image for rasbperry pi Build own docker image for raspberry pi Jun 1, 2020
@SadeghHayeri
Copy link
Owner

Thanks for your PR.
I will build and push your docker file with arm tag. can use change the build istructions to use sadeghhayeri/green-tunnel:arm?

@ardinusawan
Copy link
Contributor Author

sure @SadeghHayeri

@ardinusawan
Copy link
Contributor Author

Done @SadeghHayeri , please check

@SadeghHayeri
Copy link
Owner

Nice, please resolve the second discussion too.

@ardinusawan
Copy link
Contributor Author

Nice, please resolve the second discussion too.

@SadeghHayeri You mean this? Hm how to resolve ya? 🤔

@SadeghHayeri
Copy link
Owner

"
I think it's better to do not duplicate docker-file. Instead, insert this line (commented) under the main Dockerfile.
"

@ardinusawan
Copy link
Contributor Author

Done @SadeghHayeri , please check

@SadeghHayeri
Copy link
Owner

I will merge your pull request after I build and push your docker file.
Thanks,

SadeghHayeri
SadeghHayeri requested changes Jun 5, 2020
View reviewed changes
README.md Outdated
@@ -76,6 +76,51 @@ usage:
$ docker run -e 'PORT=1000' -p 8000:1000 sadeghhayeri/green-tunnel
```

### Docker on Raspberry Pi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it unnecessary, I will push your docker-file with arm tag.
Can you change the build instructions to pull and use sadeghhayeri/green-tunnel:arm for Raspberry-pi?

Dockerfile-raspberrypi Outdated
@@ -0,0 +1,26 @@
FROM balenalib/raspberry-pi-alpine-node
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to do not duplicate docker-file. Instead, insert this line (commented) under the main Dockerfile.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ardinusawan I mean this!

@SadeghHayeri SadeghHayeri merged commit 03a6433 into SadeghHayeri:master Jun 5, 2020
@ardinusawan ardinusawan mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SadeghHayeri SadeghHayeri SadeghHayeri requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ardinusawan @SadeghHayeri