PHP8 Support #68
Merged
PHP8 Support #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther than relying on opt-in w/suggest, they ask developers to use the "replace" method to opt-out. It's not its intended purpose, but we're painted into a corner here. Passwdqc is not yet supported on PHP8, so I'm removing it for now. zxcvbn is better anyways! Halite now throws errrors in specific uses of HiddenString, so we are using the getString method to solve that. laminas/console is deprecated, so we are adding the only method we were using onto the main module (isConsole) for dev. I'll line it up into a domain-proper location later on.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer updated to add a massive set of laminas/laminas-cache exclusions. Rather than relying on opt-in w/suggest, they ask developers to use the "replace" method to opt-out. It's not its intended purpose, but we're painted into a corner here. Will test impact on satellite projects after packages gets this PR.
Passwdqc is not yet supported on PHP8, so I'm removing it for now. zxcvbn is better anyways!
Halite now throws errrors in specific uses of HiddenString, so we are using the getString method to solve that.
laminas/console is deprecated, so we are adding the only method we were using onto the main module (isConsole) for dev. I'll line it up into a domain-proper location later on.