Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

docs: set site_url to fix broken 404 page on RTD #1325

Merged
merged 4 commits into from
Jul 11, 2023
Merged

docs: set site_url to fix broken 404 page on RTD #1325

merged 4 commits into from
Jul 11, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 5, 2023

Summary of Changes

The 404 page was previously not properly rendered on Read the Docs (RTD). This PR overrides the build commands of RTD. While this makes the 404 page work properly, it also removes the RTD flyout to select a version. For now, however, we deem the 404 page as more essential.

Once readthedocs/readthedocs.org#8529 is done, we can use the default build again to make everything work as expected.

@lars-reimann lars-reimann added the third party We need to wait for someone else label Apr 5, 2023
@lars-reimann
Copy link
Member Author

lars-reimann commented Apr 5, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.62s
✅ YAML prettier 1 0 0 1.13s
✅ YAML v8r 1 0 2.72s
✅ YAML yamllint 1 0 0.27s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #1325 (474ac40) into main (e39d83d) will increase coverage by 10.73%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1325       +/-   ##
===========================================
+ Coverage   57.01%   67.75%   +10.73%     
===========================================
  Files          86       40       -46     
  Lines        7091     1907     -5184     
  Branches      668      371      -297     
===========================================
- Hits         4043     1292     -2751     
+ Misses       2693      551     -2142     
+ Partials      355       64      -291     
Components Coverage Δ
backend 81.66% <ø> (ø)
desktop 2.67% <ø> (ø)
gui ∅ <ø> (∅)

see 46 files with indirect coverage changes

@lars-reimann lars-reimann marked this pull request as ready for review July 11, 2023 08:39
@lars-reimann lars-reimann merged commit 1a0de42 into main Jul 11, 2023
6 checks passed
@lars-reimann lars-reimann deleted the 404 branch July 11, 2023 08:40
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 1.93.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Included in a release third party We need to wait for someone else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants