Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: send JSON report to Codecov #527

Merged
merged 3 commits into from
Jul 4, 2023
Merged

ci: send JSON report to Codecov #527

merged 3 commits into from
Jul 4, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jul 4, 2023

Summary of Changes

If the clover.xml report is sent to Codecov lines with conditionals are incorrectly marked as only partially covered (see this issue). We are now send the JSON report instead to get a more accurate picture of the code coverage.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #527 (1181d87) into main (922af22) will increase coverage by 20.37%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #527       +/-   ##
===========================================
+ Coverage   79.00%   99.37%   +20.37%     
===========================================
  Files           7        7               
  Lines        1124     1124               
  Branches      229      229               
===========================================
+ Hits          888     1117      +229     
  Misses          7        7               
+ Partials      229        0      -229     
Components Coverage Δ
dsl 99.36% <ø> (+20.61%) ⬆️
runner 100.00% <ø> (ø)

see 4 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 2 0 0 1.44s
✅ JSON jsonlint 2 0 0.21s
✅ JSON npm-package-json-lint yes no 0.59s
✅ JSON prettier 2 0 0 0.86s
✅ JSON v8r 2 0 5.03s
✅ REPOSITORY git_diff yes no 0.05s
✅ TYPESCRIPT eslint 1 0 0 2.85s
✅ TYPESCRIPT prettier 1 0 0 0.79s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann changed the title build: use istanbul as test coverage provider ci: send JSON report to Codecov Jul 4, 2023
@lars-reimann lars-reimann marked this pull request as ready for review July 4, 2023 17:32
@lars-reimann lars-reimann merged commit 6a65649 into main Jul 4, 2023
11 checks passed
@lars-reimann lars-reimann deleted the istanbul-coverage branch July 4, 2023 17:32
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant