Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: set site_url to fix broken 404 page on RTD #89

Merged
merged 3 commits into from
Jul 11, 2023
Merged

docs: set site_url to fix broken 404 page on RTD #89

merged 3 commits into from
Jul 11, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 5, 2023

Summary of Changes

The 404 page was previously not properly rendered on Read the Docs (RTD). This PR overrides the build commands of RTD. While this makes the 404 page work properly, it also removes the RTD flyout to select a version. For now, however, we deem the 404 page as more essential.

Once readthedocs/readthedocs.org#8529 is done, we can use the default build again to make everything work as expected.

@lars-reimann lars-reimann added the third party We need to wait for someone else label Apr 5, 2023
@lars-reimann
Copy link
Member Author

lars-reimann commented Apr 5, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.03s
✅ YAML prettier 1 0 0 0.43s
✅ YAML v8r 1 0 1.66s
✅ YAML yamllint 1 0 0.19s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #89 (ce3f703) into main (29abdb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          87       87           
  Lines        4524     4524           
=======================================
  Hits         4132     4132           
  Misses        392      392           

@lars-reimann lars-reimann marked this pull request as ready for review July 11, 2023 08:24
@lars-reimann lars-reimann requested a review from a team as a code owner July 11, 2023 08:24
@lars-reimann lars-reimann merged commit 85b5341 into main Jul 11, 2023
8 checks passed
@lars-reimann lars-reimann deleted the 404 branch July 11, 2023 08:24
@lars-reimann lars-reimann removed the third party We need to wait for someone else label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant