Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Maintain tagging in methods inherited from Table class #332

Merged

Conversation

zzril
Copy link
Contributor

@zzril zzril commented May 29, 2023

Closes #58.

Summary of Changes

  • Overrode methods in TaggedTable inherited from Table to maintain tagging.
  • Introduced new exceptions to be thrown when the overriden method cannot be applied
  • Added tests.

@zzril zzril linked an issue May 29, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member

lars-reimann commented May 29, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 39 0 0 1.95s
✅ PYTHON mypy 39 0 2.8s
✅ PYTHON ruff 39 0 0 0.13s
✅ REPOSITORY git_diff yes no 0.08s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #332 (ff3782b) into main (8e9065c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #332   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2436      2514   +78     
=========================================
+ Hits          2436      2514   +78     
Impacted Files Coverage Δ
src/safeds/exceptions/__init__.py 100.00% <ø> (ø)
src/safeds/data/tabular/containers/_table.py 100.00% <100.00%> (ø)
...rc/safeds/data/tabular/containers/_tagged_table.py 100.00% <100.00%> (ø)
...ds/data/tabular/transformation/_one_hot_encoder.py 100.00% <100.00%> (ø)
src/safeds/exceptions/_data.py 100.00% <100.00%> (ø)
src/safeds/ml/classical/_util_sklearn.py 100.00% <100.00%> (ø)

src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/data/tabular/containers/_tagged_table.py Outdated Show resolved Hide resolved
src/safeds/exceptions/_data.py Outdated Show resolved Hide resolved
Co-authored-by: patrikguempel <patrikguempel@gmail.com>
patrikguempel
patrikguempel previously approved these changes Jul 7, 2023
Copy link
Contributor

@patrikguempel patrikguempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

zzril and others added 2 commits July 7, 2023 16:39
Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
zzril and others added 7 commits July 8, 2023 15:19
…_remove_columns_with_non_numerical_values.py

Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
…_keep_only_columns.py

Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
Co-authored-by: Simon Breuer <86068340+sibre28@users.noreply.github.com>
@zzril zzril requested a review from sibre28 July 8, 2023 13:43
Copy link
Contributor

@sibre28 sibre28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzril zzril merged commit bc73a6c into main Jul 9, 2023
8 checks passed
@zzril zzril deleted the 58-in-taggedtable-override-methods-of-table-that-return-a-table branch July 9, 2023 19:55
lars-reimann pushed a commit that referenced this pull request Jul 13, 2023
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In TaggedTable override methods of Table that return a Table
6 participants