feat: Added and improved errors and warnings in the table transformers #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aviour with multiple most frequent values Co-authored-by: alex-senger <91055000+alex-senger@users.noreply.github.com>
feat: Added ability for the `Imputer` with strategy `Mode` to work if multiple most frequent values (warns if this is the case, takes the lowest most frequent value) feat: Added ability for the `OneHotEncoder` to encode python NaNs fix: fixed grammar in `NonNumericColumnError` feat: Changed `ValueNotPresentWhenFittedError` to allow info about multiple columns test: Changed test for `Imputer` to test all strategies Co-authored-by: alex-senger <91055000+alex-senger@users.noreply.github.com>
…rove-error-handling-of-table-transformers # Conflicts: # src/safeds/exceptions/_data.py # tests/safeds/data/tabular/containers/_table/test_plot_boxplots.py
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #372 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 2296 2382 +86
=========================================
+ Hits 2296 2382 +86
|
…nsform contains no null values refactor: Added changes to satisfy the Linters
patrikguempel
approved these changes
Jun 23, 2023
jxnior01
approved these changes
Jun 23, 2023
robmeth
reviewed
Jun 23, 2023
Comment on lines
+128
to
+147
| if table.number_of_rows == 0: | ||
| raise ValueError("The Imputer cannot be fitted because the table contains 0 rows") | ||
|
|
||
| if (isinstance(self._strategy, Imputer.Strategy.Mean | Imputer.Strategy.Median)) and table.keep_only_columns( | ||
| column_names, | ||
| ).remove_columns_with_non_numerical_values().number_of_columns < len( | ||
| column_names, | ||
| ): | ||
| raise NonNumericColumnError( | ||
| str( | ||
| sorted( | ||
| set(table.keep_only_columns(column_names).column_names) | ||
| - set( | ||
| table.keep_only_columns(column_names) | ||
| .remove_columns_with_non_numerical_values() | ||
| .column_names, | ||
| ), | ||
| ), | ||
| ), | ||
| ) |
There was a problem hiding this comment.
maybe put the NonNumericColumnError before the ValueError to keep the order of Errors the same as in the other transformations
lars-reimann
pushed a commit
that referenced
this pull request
Jun 30, 2023
## [0.14.0](v0.13.0...v0.14.0) (2023-06-30) ### Features * 290 properties for width-height of image ([#359](#359)) ([d9ebdc1](d9ebdc1)), closes [#290](#290) * Add `find_edges` method to `Image` class ([#383](#383)) ([d14b6ce](d14b6ce)), closes [#288](#288) * Add `StandardScaler` transformer ([#316](#316)) ([57b0572](57b0572)), closes [#142](#142) * Add docstrings to the getter methods for hyperparameters in Regression and Classification models ([#371](#371)) ([9073f04](9073f04)), closes [#313](#313) * Added `Table.group_by` to group a table by a given key ([#343](#343)) ([afb98be](afb98be)), closes [#160](#160) * Added and improved errors and warnings in the table transformers ([#372](#372)) ([544e307](544e307)), closes [#152](#152) * added crop() method in image and tests ([#365](#365)) ([eba8163](eba8163)) * added invert_colors method ([#367](#367)) ([1e4d110](1e4d110)) * adjust brightness and contrast of image ([#368](#368)) ([1752feb](1752feb)), closes [#289](#289) [#291](#291) * blur Image method ([#363](#363)) ([c642176](c642176)) * check that methods of table can handle an empty table ([#314](#314)) ([686c2e7](686c2e7)), closes [#123](#123) * convert image to grayscale ([#366](#366)) ([1312fe7](1312fe7)), closes [#287](#287) * enhance `replace_column` to accept a list of new columns ([#312](#312)) ([d50c5b5](d50c5b5)), closes [#301](#301) * Explicitly throw `UnknownColumnNameError` in `TaggedTable._from_table` ([#334](#334)) ([498999f](498999f)), closes [#333](#333) * flip images / eq method for image ([#360](#360)) ([54f4ae1](54f4ae1)), closes [#280](#280) * improve `table.summary`. Catch `ValueError` thrown by `column.stability` ([#390](#390)) ([dbbe0e3](dbbe0e3)), closes [#320](#320) * improve error handling of `column.stability` when given a column that contains only None ([#388](#388)) ([1da2499](1da2499)), closes [#319](#319) * Improve Error Handling of classifiers and regressors ([#355](#355)) ([66f5f64](66f5f64)), closes [#153](#153) * Resize image ([#354](#354)) ([3a971ca](3a971ca)), closes [#283](#283) * rotate_left and rotate_right added to Image ([#361](#361)) ([c877530](c877530)), closes [#281](#281) * set kernel of support vector machine ([#350](#350)) ([1326f40](1326f40)), closes [#172](#172) * sharpen image ([#364](#364)) ([3444700](3444700)), closes [#286](#286) ### Bug Fixes * Keeping no columns with Table.keep_only_columns results in an empty Table with a row count above 0 ([#386](#386)) ([15dab06](15dab06)), closes [#318](#318) * remove default value of `positive_class` parameter of classifier metrics ([#382](#382)) ([58fc09e](58fc09e)) * remove default value of `radius` parameter of `blur` ([#378](#378)) ([7f07f29](7f07f29))
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152.
Summary of Changes
feat: Added and improved errors and warnings in the table transformers
feat: Added ability for the
Imputerwith strategyModeto work if multiple most frequent values (warns if this is the case, takes the lowest most frequent value)feat: Added ability for the
OneHotEncoderto encode python NaNsfix: fixed grammar in
NonNumericColumnErrorfeat: Changed
ValueNotPresentWhenFittedErrorto allow info about multiple columnstest: Changed test for
Imputerto test all strategies