Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve layout of 404 error page #443

Closed
zzril opened this issue Jul 10, 2023 · 3 comments · Fixed by #176
Closed

Improve layout of 404 error page #443

zzril opened this issue Jul 10, 2023 · 3 comments · Fixed by #176
Assignees
@lars-reimann
Labels
documentation 📖 Improvements or additions to documentation released Included in a release

Comments

@zzril
Copy link
Contributor

zzril commented Jul 10, 2023 •
edited
Loading

Is your feature request related to a problem?

When visiting a non-existing link within stdlib.safeds.com, such as https://stdlib.safeds.com/en/stable/thispagecertainlydoesnotexist, one gets shown a 404 error page with a quite messed up layout. Images are way too large, and it looks like no CSS is loaded.

Desired solution

Create a proper 404 error page.
@zzril zzril added documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request cleanup 🧹 Refactorings and other tasks that improve the code labels Jul 10, 2023
@lars-reimann lars-reimann mentioned this issue Jul 11, 2023
Merged
@lars-reimann lars-reimann self-assigned this Jul 11, 2023
@lars-reimann lars-reimann added third party We need to wait for someone else and removed enhancement 💡 New feature or request cleanup 🧹 Refactorings and other tasks that improve the code labels Jul 11, 2023
lars-reimann added a commit that referenced this issue Jul 11, 2023
@lars-reimann
docs: set site_url to fix broken 404 page on RTD (#176)
de04e2a 
Closes #443

### Summary of Changes

The 404 page was previously not properly rendered on Read the Docs
(RTD). This PR overrides the build commands of RTD. While this makes the
404 page work properly, it also removes the RTD flyout to select a
version. For now, however, we deem the 404 page as more essential.

Once readthedocs/readthedocs.org#8529 is done,
we can use the default build again to make everything work as expected.
@lars-reimann lars-reimann removed the third party We need to wait for someone else label Jul 11, 2023
@zzril
Copy link
Contributor Author

zzril commented Jul 11, 2023 •
edited
Loading

Is this actually fixed?

I still get the strange layout when visiting the above link.

Clearing browser cache doesn't make a difference.

@zzril zzril reopened this Jul 11, 2023
@zzril
Copy link
Contributor Author

zzril commented Jul 11, 2023

Nvm, just isn't deployed yet.

Works fine when building locally.

@zzril zzril closed this as completed Jul 11, 2023
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
documentation 📖 Improvements or additions to documentation released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: set site_url to fix broken 404 page on RTD Safe-DS/Library
2 participants
@lars-reimann @zzril