Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added plot_lagplot #548

Merged
merged 22 commits into from
Feb 20, 2024
Merged

Conversation

Gerhardsa0
Copy link
Contributor

@Gerhardsa0 Gerhardsa0 commented Feb 20, 2024

Closes #519

Summary of Changes

I added the visualization of the lag plot.

wanna add normal plot next, mby need some help for warning and errors with visualization
@Gerhardsa0 Gerhardsa0 requested a review from a team as a code owner February 20, 2024 09:05
@Gerhardsa0 Gerhardsa0 linked an issue Feb 20, 2024 that may be closed by this pull request
@Gerhardsa0 Gerhardsa0 changed the title added lag_plot feat: added lag_plot Feb 20, 2024
Copy link
Contributor

github-actions bot commented Feb 20, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 0.83s
✅ PYTHON mypy 3 0 1.82s
✅ PYTHON ruff 3 0 0 0.16s
✅ REPOSITORY git_diff yes no 0.25s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f44c34d) 100.00% compared to head (4560e4e) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines         2852      2866   +14     
=========================================
+ Hits          2852      2866   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lars-reimann
lars-reimann previously approved these changes Feb 20, 2024
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, feel free to merge it in when you're done with it.

@Gerhardsa0 Gerhardsa0 enabled auto-merge (squash) February 20, 2024 15:15
@lars-reimann lars-reimann changed the title feat: added lag_plot feat: added plot_lagplot Feb 20, 2024
@Gerhardsa0 Gerhardsa0 merged commit 0fb38d2 into main Feb 20, 2024
10 checks passed
@Gerhardsa0 Gerhardsa0 deleted the 519-feat-add-lag-plot-for-time-series branch February 20, 2024 16:40
lars-reimann pushed a commit that referenced this pull request Apr 3, 2024
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03)

### Features

* add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7))
* add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522)
* add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee))
* added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519)
* added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549)
* when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571)

### Bug Fixes

* incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53))
* mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add lag-plot for time series
3 participants