Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupportVectorMachine.get_sklearn_kernel should be internal #582

Closed
lars-reimann opened this issue Mar 29, 2024 · 1 comment · Fixed by #587
Closed

SupportVectorMachine.get_sklearn_kernel should be internal #582

lars-reimann opened this issue Mar 29, 2024 · 1 comment · Fixed by #587
Assignees
Labels
bug 🪲 Something isn't working released Included in a release

Comments

@lars-reimann
Copy link
Member

Describe the bug

The function SupportVectorMachine.get_sklearn_kernel is missing an underscore to mark it as internal. This affects the regression and the classification version.

To Reproduce

/

Expected behavior

/

Screenshots (optional)

No response

Additional Context (optional)

No response

@lars-reimann lars-reimann added the bug 🪲 Something isn't working label Mar 29, 2024
@lars-reimann lars-reimann self-assigned this Mar 30, 2024
@lars-reimann lars-reimann linked a pull request Mar 30, 2024 that will close this issue
lars-reimann added a commit that referenced this issue Mar 30, 2024
Closes #582
Closes #585

### Summary of Changes

Mark the following API elements as internal:

* Static method `Schema.merge_multiple_schemas`
* Instance method `SupportVectorMachineKernel.get_sklearn_kernel`
* Module `config`

---------

Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Apr 3, 2024
## [0.20.0](v0.19.0...v0.20.0) (2024-04-03)

### Features

* add deterministic hash methods to all types ([#573](#573)) ([f6a3ca7](f6a3ca7))
* add fnn functionality ([#529](#529)) ([ce53153](ce53153)), closes [#522](#522)
* add suffixes to models to indicate their task ([#588](#588)) ([d490dee](d490dee))
* added lag_plot ([#548](#548)) ([0fb38d2](0fb38d2)), closes [#519](#519)
* added normal plot for time series ([#550](#550)) ([dbdf11e](dbdf11e)), closes [#549](#549)
* when using from table to time series feature must be given ([#572](#572)) ([ca23f0f](ca23f0f)), closes [#571](#571)

### Bug Fixes

* incorrect type hint for `number_of_bins` parameter ([#567](#567)) ([b434e53](b434e53))
* mark various API elements as internal ([#587](#587)) ([ea176fc](ea176fc)), closes [#582](#582) [#585](#585)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working released Included in a release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant