feat: return new model when calling fit
#91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
+ Coverage 91.53% 92.11% +0.57%
==========================================
Files 36 36
Lines 1134 1230 +96
==========================================
+ Hits 1038 1133 +95
- Misses 96 97 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lars-reimann
pushed a commit
that referenced
this pull request
Mar 27, 2023
## [0.6.0](v0.5.0...v0.6.0) (2023-03-27) ### Features * allow calling `correlation_heatmap` with non-numerical columns ([#92](#92)) ([b960214](b960214)), closes [#89](#89) * function to drop columns with non-numerical values from `Table` ([#96](#96)) ([8f14d65](8f14d65)), closes [#13](#13) * function to drop columns/rows with missing values ([#97](#97)) ([05d771c](05d771c)), closes [#10](#10) * remove `list_columns_with_XY` methods from `Table` ([#100](#100)) ([a0c56ad](a0c56ad)), closes [#94](#94) * rename `keep_columns` to `keep_only_columns` ([#99](#99)) ([de42169](de42169)) * rename `remove_outliers` to `drop_rows_with_outliers` ([#95](#95)) ([7bad2e3](7bad2e3)), closes [#93](#93) * return new model when calling `fit` ([#91](#91)) ([165c97c](165c97c)), closes [#69](#69) ### Bug Fixes * handling of missing values when dropping rows with outliers ([#101](#101)) ([0a5e853](0a5e853)), closes [#7](#7)
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69.
Summary of Changes
The
fitmethod of classifiers/regressors now returns a new (fitted) classifier regressor. The receiver of the method call is not changed anymore. This is consistent with the methods on theTableclass and other data containers. Furthermore,fitis now a pure function, which works better in notebooks and our own execution strategy.