Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename remove_outliers method of Table #93

Closed
lars-reimann opened this issue Mar 27, 2023 · 1 comment · Fixed by #95
Closed

Rename remove_outliers method of Table #93

lars-reimann opened this issue Mar 27, 2023 · 1 comment · Fixed by #95
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Mar 27, 2023 •
edited

Is your feature request related to a problem?

The method Table.remove_outliers does not match the naming schema of the other methods that delete data like drop_columns or drop_duplicate_rows. In particular, it is not clear whether it operates on rows or columns.

Desired solution

Call it drop_rows_with_outliers instead.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Mar 27, 2023
@lars-reimann lars-reimann self-assigned this Mar 27, 2023
@lars-reimann lars-reimann mentioned this issue Mar 27, 2023
Merged
@lars-reimann lars-reimann linked a pull request Mar 27, 2023 that will close this issue
feat: rename remove_outliers to drop_rows_with_outliers #95
Merged
lars-reimann added a commit that referenced this issue Mar 27, 2023
@lars-reimann
feat: rename remove_outliers to drop_rows_with_outliers (#95)
7bad2e3 
Closes #93.

### Summary of Changes

Rename `remove_outliers` to `drop_rows_with_outliers` in `Table`.
lars-reimann pushed a commit that referenced this issue Mar 27, 2023
@semantic-release-bot
chore(release): 0.6.0 [skip ci]
3931ce9 
## [0.6.0](v0.5.0...v0.6.0) (2023-03-27)

### Features

* allow calling `correlation_heatmap` with non-numerical columns ([#92](#92)) ([b960214](b960214)), closes [#89](#89)
* function to drop columns with non-numerical values from `Table` ([#96](#96)) ([8f14d65](8f14d65)), closes [#13](#13)
* function to drop columns/rows with missing values ([#97](#97)) ([05d771c](05d771c)), closes [#10](#10)
* remove `list_columns_with_XY` methods from `Table` ([#100](#100)) ([a0c56ad](a0c56ad)), closes [#94](#94)
* rename `keep_columns` to `keep_only_columns` ([#99](#99)) ([de42169](de42169))
* rename `remove_outliers` to `drop_rows_with_outliers` ([#95](#95)) ([7bad2e3](7bad2e3)), closes [#93](#93)
* return new model when calling `fit` ([#91](#91)) ([165c97c](165c97c)), closes [#69](#69)

### Bug Fixes

* handling of missing values when dropping rows with outliers ([#101](#101)) ([0a5e853](0a5e853)), closes [#7](#7)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: rename remove_outliers to drop_rows_with_outliers Safe-DS/Library
1 participant
@lars-reimann