Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve structure of tests for Column #246

Merged
merged 10 commits into from
Apr 23, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Apr 23, 2023

Closes #148.

Summary of Changes

  • One test file per method (putting them all in one file would be unwieldy)
  • Add missing tests

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #246 (6e79519) into main (a35b943) will increase coverage by 0.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   98.62%   99.20%   +0.58%     
==========================================
  Files          44       44              
  Lines        1523     1518       -5     
==========================================
+ Hits         1502     1506       +4     
+ Misses         21       12       -9     
Impacted Files Coverage Δ
src/safeds/data/tabular/containers/_column.py 100.00% <100.00%> (+5.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lars-reimann
Copy link
Member Author

lars-reimann commented Apr 23, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 38 0 0 1.19s
✅ PYTHON mypy 38 0 2.75s
✅ PYTHON ruff 38 0 0 0.07s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann marked this pull request as ready for review April 23, 2023 14:52
@lars-reimann lars-reimann requested a review from a team as a code owner April 23, 2023 14:52
@lars-reimann lars-reimann merged commit a999152 into main Apr 23, 2023
@lars-reimann lars-reimann deleted the improve-structure-of-column-tests branch April 23, 2023 14:57
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling of Column
2 participants