fix: handle empty string for PROXY_HOST and PROXY_PORT (#4)

Safe-Security · Sep 30, 2021 · cce2462 · cce2462
1 parent bb5dde7
commit cce2462
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -4,7 +4,7 @@ import * as tunnel from "tunnel";
 const { PROXY_HOST, PROXY_PORT, PROXY_USERNAME, PROXY_PASSWORD } = process.env;
 
 const isProxyDefined = (): boolean => {
-    return PROXY_HOST !== undefined && PROXY_PORT !== undefined;
+    return !!PROXY_HOST && !!PROXY_PORT;
 };
 
 const getProxyAuth = (): string | undefined => {

diff --git a/tests/praxios.test.ts b/tests/praxios.test.ts
@@ -62,4 +62,14 @@ describe("praxios", () => {
 
         expect(praxios.defaults.httpsAgent.proxyOptions.localAddress).toBeUndefined();
     });
+
+    test("empty string for proxy host options are assumed as proxy not being set", async () => {
+        process.env.PROXY_HOST = "";
+        process.env.PROXY_PORT = "";
+
+        const praxios = (await import("../src/index")).default;
+
+        expect(praxios.defaults.httpsAgent).toBeUndefined();
+        expect(praxios.defaults.proxy).toBeUndefined();
+    });
 });