Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file not loading via seb:// #4

Closed
ramonavic opened this issue Mar 31, 2020 · 8 comments
Closed

Configuration file not loading via seb:// #4

ramonavic opened this issue Mar 31, 2020 · 8 comments
Assignees
Milestone

Comments

@ramonavic
Copy link

ramonavic commented Mar 31, 2020

Hi!

After testing the SEB 3.0.0 Beta, we ran into an issue when opening the configuration file through a seb:// url.

After clicking the sebs:// link, SEB does open, but it does not load the configuration file. Instead, SEB displays the text of the configuration file.
We use document.location to redirect to the seb:// url.

When saving the same configuration to a .seb file and then opening it, the configuration loads without problems.

The log files are attached. Is there something we should change on our end, or is this an issue in the SEB application?

seb-logs.zip

Thanks in advance!

@ramonavic ramonavic changed the title Configuration file not loading via sebs:// Configuration file not loading via seb:// Mar 31, 2020
@dbuechel
Copy link
Member

Thanks for your feedback. Are you clicking on a seb(s)-link inside SEB, or outside in a normal browser? Also, would you have a test page where I can debug the issue?

SEB should correctly recognize configuration files as long as reconfiguring is allowed in the currently active configuration.

@dbuechel dbuechel self-assigned this Mar 31, 2020
@dbuechel dbuechel added this to the 3.0.0 milestone Mar 31, 2020
@ramonavic
Copy link
Author

Thanks for you quick response!
We're clicking the seb:// url in a regular browser (tested in Firefox and Edge).
We've set up an account for you to try it out yourself. After logging in you should immediately see the SEB start button.

I've emailed the credentials to you.

@dbuechel
Copy link
Member

Excellent, I have received them, thanks. I will have a look at the problem first thing tomorrow.

@dbuechel
Copy link
Member

dbuechel commented Apr 1, 2020

Okay, I was able to reproduce the issue. Can you elaborate on your comment below, is it that the seb-URL you use leads to an HTML page which then redirects to the actual configuration file?

We use document.location to redirect to the seb:// url.

According to the log file, SEB detects that the resource under the given seb-URL is HTML and thus attempts to load it with the browser. As to why it renders the configuration file instead of loading it I will try to find out now...

@dbuechel
Copy link
Member

dbuechel commented Apr 1, 2020

I think I found the root cause: You are returning "text/html" as content-type in the response for the configuration file request. Thus the browser simply renders the content instead of initiating a file download...

@ramonavic
Copy link
Author

Makes sense! We're going to check if this helps. I'll get back to you after :)

@ramonavic
Copy link
Author

@dbuechel we have changed our headers and it works now! We'll be deploying it to production soon. Thanks for you help!

@dbuechel
Copy link
Member

dbuechel commented Apr 2, 2020

Great! Thanks for helping out with the beta testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants