Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSE-69] Include asset_id on relevant tables #44

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[CSE-69] Include asset_id on relevant tables #44

merged 1 commit into from
Mar 8, 2023

Conversation

BCook98
Copy link
Member

@BCook98 BCook98 commented Mar 8, 2023

Summary

Includes asset_id column on relevant tables.

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@BCook98 BCook98 requested a review from a team as a code owner March 8, 2023 09:54
@BCook98 BCook98 requested a review from MickStanciu March 8, 2023 09:54
@BCook98 BCook98 merged commit bc35dbc into main Mar 8, 2023
@BCook98 BCook98 deleted the CSE-69 branch March 8, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants