Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-3513] Domain prefix for the message names in yaml files #127

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

junggyu-sc
Copy link
Contributor

@junggyu-sc junggyu-sc commented Apr 4, 2023

Summary

Added a domain name prefix for the message names in yaml files. Both assets and templates domains have the same file name template and a message name Template.

  1. api_generator.cc change
  2. run make cruxclient and and changed (generated) files
  3. release(https://github.com/SafetyCulture/s12-proto/releases) : select Draft a new release, the rest is same with crux release.

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@junggyu-sc junggyu-sc marked this pull request as ready for review April 4, 2023 23:51
@junggyu-sc junggyu-sc merged commit 4126c2d into master Apr 5, 2023
@junggyu-sc junggyu-sc deleted the MOB-3513-domain-prefix branch April 5, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants