Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS-923 Generate for nested messages #50

Merged
merged 1 commit into from
Apr 28, 2020
Merged

PS-923 Generate for nested messages #50

merged 1 commit into from
Apr 28, 2020

Conversation

codingrhythm
Copy link
Member

@codingrhythm codingrhythm commented Apr 28, 2020 •
edited
Loading

Currently the cruxclient code generator doesn't handle the nested messages, this PR adds support to it

ggndpsingh
ggndpsingh approved these changes Apr 28, 2020
View reviewed changes
Copy link

@ggndpsingh ggndpsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codingrhythm codingrhythm merged commit 29638fb into master Apr 28, 2020
@codingrhythm codingrhythm deleted the PS-923 branch April 28, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggndpsingh ggndpsingh ggndpsingh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codingrhythm @ggndpsingh