Fix marshaling on JNI from jobject to cpp #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoura10
force-pushed
the
Fix-JniMarshalingFromJObjectToCpp
branch
from
83014bb
to
5404d7a
Compare
codingrhythm
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #58 I've fixed a JNI crash but I didn't realize that the marshaling of the objects was incorrect (the
cpp_message.ParseFromArray(b, byte_len);was returningfalse).To correctly use the
ParseFromArray, we should provide ajbyte. So, in this PR I'm converting thejobjectto ajbyte*before use theParseFromArray.