[GOMOD-31] Use sc-go.io/pkg/jwtclaims instead of s12-utils-go/utils
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of [WCE 4.12](https://safetyculture.atlassian.net/wiki/spaces/ENG/pages/2081919949/4.12+Enable+more+effective+reuse+of+Go+Code+by+introducing+a+repository+of+shared+modules), we're extracting out packages originally from s12-utils-go into self-contained packages. SafetyCulture/s12-modules-go#36
alabeduarte
commented
Oct 14, 2021
Comment on lines
+6
to
+14
| github.com/SafetyCulture/s12-apis-go v1.128.45 | ||
| github.com/SafetyCulture/s12-proto v1.13.1 | ||
| github.com/SafetyCulture/s12-utils-go v1.23.4 | ||
| github.com/SafetyCulture/soter-jwt-go v2.0.0+incompatible | ||
| github.com/nats-io/jwt v1.2.2 | ||
| github.com/tj/assert v0.0.3 | ||
| go.uber.org/zap v1.19.1 | ||
| google.golang.org/grpc v1.40.0 | ||
| sc-go.io/pkg/jwtclaims v1.1.4 |
There was a problem hiding this comment.
I wouldn't expect these many packages to be added, but I guess this was correct from the generated files. This was added when I ran go get sc-go.io/pkg/jwtclaims followed by go mod tidy
rogchap
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're extracting out packages originally from s12-utils-go into self-contained packages.
Example Go file was regenerated with the following steps:
Which then changed the file
protobuf/protoc-gen-s12perm/example/example.perm.pb.go