Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Organize HttpStore backend tests #30

Closed
white-gecko opened this issue May 8, 2015 · 7 comments
Closed

Organize HttpStore backend tests #30

white-gecko opened this issue May 8, 2015 · 7 comments

Comments

@white-gecko
Copy link
Member

Make out of HttpAbstractTest and HttpUnitTest one HttpTest which extends the StoreAbstractTest. If some of the tests in HttpUnitTest are needed, migrate them to StoreAbstractTest.

@k00ni
Copy link
Member

k00ni commented May 8, 2015

Are the HTTP backend tests now fine?

@k00ni
Copy link
Member

k00ni commented May 21, 2015

Should be fine now.

@k00ni k00ni closed this as completed May 21, 2015
@white-gecko
Copy link
Member Author

The test case is still called HttpAbstractTest and most of the tests fail for me.

@white-gecko white-gecko reopened this May 21, 2015
k00ni added a commit that referenced this issue May 21, 2015
k00ni added a commit that referenced this issue Jun 1, 2015
…sary) #30

HttpTest now checks for each test, if the target store supports
graph creation/deletion and triple querying/creation/deletion. If
not, the test will be marked as skipped.

The according check-method called getRights is very basic and
you could end up with empty graphs, just created to test something.
Unless, there is no better way how to check all the stuff, the
method will not be part of the constructor.
@k00ni
Copy link
Member

k00ni commented Jun 1, 2015

From now on, all HTTP related tests will be skipped if the adapter is not able to create/drop graphs or update or query triples. The test for that is still a little bit basic and stupid, but it works.

Because you did not have configured your Virtuoso properly to act as a read/write endpoint, all HTTP tests should skip for you @white-gecko.

What remains here:

  • document that new behavior

@white-gecko
Copy link
Member Author

Could we maybe add some instructions for the correct configuration of the HTTP endpoint?

@k00ni
Copy link
Member

k00ni commented Jun 2, 2015

Could we maybe add some instructions for the correct configuration of the HTTP endpoint?

Can you please tell me if the following (fresh new) guide is enough? http://safting.github.io/doc/phpframework/backends/httpstore/

@k00ni
Copy link
Member

k00ni commented Jun 2, 2015

I documented that behavior here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants