Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-1239] Update data guide for 16.0-public #20

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Conversation

Chelsea-Na
Copy link
Collaborator

  • Added the crosswalk table between files
  • Added general updates to the field and file descriptions
  • Re-arranged some of the sections for clarity
  • Added minor edits for clarity

@Chelsea-Na Chelsea-Na requested a review from a team as a code owner June 19, 2024 22:02
Copy link

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes here!

Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 thanks for the review Bryan and great work here Chelsea. See my comments but I'm going to pre-approve!

scripts/data_guide/data_guide.qmd Show resolved Hide resolved
- Intervals are redacted with ">32485" and "<6570"
- Ages are redacted with ">89" and "<18"
- Years are redacted with "cannotReleaseHIPAA" and "withheld".
- Intervals are redacted with "\>32485" and "<6570"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the \?

scripts/data_guide/data_guide.qmd Outdated Show resolved Hide resolved

- Every single row of your bed file will be matched against the gene database. If the submitted symbol matches a row in the gene database and there is an overlap from the submitted bed region, the submitted symbol will be returned.
- Every single row of the bed file will be matched against the gene database. If the submitted symbol matches a row in the gene database and there is an overlap from the submitted bed region, the submitted symbol will be returned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to say how we build the gene database?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we build the gene database?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Jun 26, 2024

Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@thomasyu888 thomasyu888 merged commit 2ce5aec into main Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants