-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No score in e-mail for PEGS #40
Conversation
@@ -46,7 +46,7 @@ profiles { | |||
params.goldstandard_id = "syn58888786" | |||
params.private_folders = "predictions" | |||
params.challenge_container = "ghcr.io/sage-bionetworks-challenges/pegs-evaluation:latest" | |||
params.send_email = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are a confusing set of parameters - Do we have any control to update this?
I would assume that we would be setting:
send_email = true
at a base level that determines Yes/No we are sending at an email at all. Then come the flags to modify the content that would be included in the email such as:
include_score_in_email
True/False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see from the docs that send_email
defaults to true. Since we are modifying the flags around it I would keep send_email = true
in this config so it isn't misinterpreted that email_with_score
is controlling it:
send_email
(optional): Iftrue
, sends an e-mail to the submitter on the status of their submission. Default istrue
.
Either way I understand now how this is set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good point- There's a little bit of cleanup I can do with the way e-mail templates are chosen (with/without score). One of them being the wording and the other being why one is handled with a boolean and the other with a string. I'll make a quick tech debt ticket for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve as the changes work, although the flags are slightly confusing when looking at them in a vacuum.
|
problem
We want e-mails sent out to participants, just not with a score value.
solution
Set
email_with_score
to"no"
testing
Workflow run for INVALID submission
Workflow run for VALID submission