Merge pull request #1304 from hallieswan/AG-1435

AG-1435

.eslintrc.json

@@ -11,7 +11,8 @@
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "ecmaVersion": "latest",
-    "sourceType": "module"
+    "sourceType": "module",
+    "project": ["./tsconfig.base.json"]
   },
   "plugins": ["@typescript-eslint"],
   "rules": {
@@ -23,6 +24,7 @@
     "@typescript-eslint/ban-ts-comment": "off",
     "@typescript-eslint/no-empty-interface": "off",
     "@typescript-eslint/no-empty-function": "off",
-    "@typescript-eslint/no-this-alias": "off"
+    "@typescript-eslint/no-this-alias": "off",
+    "@typescript-eslint/no-floating-promises": "warn"
   }
 }

package.json

@@ -39,7 +39,8 @@
     "mongo:start:windows": "sh ./scripts/start-mongo.sh 'C:\\data\\db'",
     "data:local": "npm run clean:data && sh ./scripts/get-data-local.sh",
     "e2e": "playwright test --trace on",
-    "e2e:ui": "playwright test --ui"
+    "e2e:ui": "playwright test --ui",
+    "e2e:update": "npm install -D @playwright/test@latest; npx playwright install --with-deps; npx playwright --version"
   },
   "pre-commit": [
     "test"
@@ -94,7 +95,7 @@
     "@angularclass/hmr": "^3.0.0",
     "@babel/plugin-proposal-decorators": "^7.18.10",
     "@ngtools/webpack": "^13.3.9",
-    "@playwright/test": "^1.39.0",
+    "@playwright/test": "^1.43.1",
     "@types/aws-param-store": "^2.1.2",
     "@types/browser-update": "^3.3.0",
     "@types/compression": "^1.7.2",

src/app/core/components/footer/footer.component.spec.ts

@@ -72,6 +72,8 @@ describe('Component: Footer', () => {
     const link = element.querySelector('.footer-logo a') as HTMLElement;
     expect(link).toBeTruthy();
 
+    // https://github.com/angular/angular/issues/45202
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     router.navigate(['/about']);
     tick();
     expect(location.path()).toBe('/about');

src/app/core/components/header/header.component.spec.ts

@@ -69,6 +69,8 @@ describe('Component: Header', () => {
     const link = element.querySelector('.header-logo a') as HTMLElement;
     expect(link).toBeTruthy();
 
+    // https://github.com/angular/angular/issues/45202
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     router.navigate(['/nominated-targets']);
     tick();
     expect(location.path()).toBe('/nominated-targets');

src/app/features/charts/components/median-barchart/median-barchart.component.spec.ts

@@ -54,8 +54,8 @@ describe('Component: BarChart - Median', () => {
   let component: MedianBarChartComponent;
   let element: HTMLElement;
 
-  beforeEach(waitForAsync(() => {
-    TestBed.configureTestingModule({
+  beforeEach(waitForAsync(async () => {
+    await TestBed.configureTestingModule({
       declarations: [MedianBarChartComponent],
       imports: [RouterTestingModule],
       providers: [HelperService],

src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.html

@@ -403,6 +403,7 @@ <h1 class="gct-heading h2">Gene Comparison Tool</h1>
                 <div *ngIf="genesTable.filteredValue?.length">
                   <button
                     class="pin-all-button"
+                    [disabled]="getPinDisabledStatus()"
                     [ngClass]="{
                       disabled: getPinDisabledStatus()
                     }"
@@ -471,6 +472,7 @@ <h1 class="gct-heading h2">Gene Comparison Tool</h1>
                       <div>
                         <button
                           (click)="onPinGeneClick(gene)"
+                          [disabled]="getPinDisabledStatus()"
                           [ngClass]="{
                             disabled: getPinDisabledStatus()
                           }"

src/app/features/genes/components/gene-comparison-tool/gene-comparison-tool.component.spec.ts

@@ -48,8 +48,8 @@ describe('Component: GeneComparisonToolComponent', () => {
   let element: HTMLElement;
   let route: ActivatedRoute;
 
-  beforeEach(fakeAsync(() => {
-    TestBed.configureTestingModule({
+  beforeEach(fakeAsync(async () => {
+    await TestBed.configureTestingModule({
       declarations: [
         GeneComparisonToolComponent,
         GeneComparisonToolDetailsPanelComponent,

src/app/features/genes/components/gene-details/gene-details.component.ts

@@ -138,6 +138,8 @@ export class GeneDetailsComponent implements OnInit, AfterViewInit {
           .subscribe((gene) => {
             if (!gene) {
               this.helperService.setLoading(false);
+              // https://github.com/angular/angular/issues/45202
+              // eslint-disable-next-line @typescript-eslint/no-floating-promises
               this.router.navigateByUrl('/404-not-found', { skipLocationChange: true });
             } else {
               this.gene = gene;

src/app/features/genes/components/gene-network/gene-network.component.ts

@@ -91,6 +91,8 @@ export class GeneNetworkComponent implements OnInit {
   }
 
   navigateToSimilarGenes() {
+    // https://github.com/angular/angular/issues/45202
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     this.router.navigate([
       '/genes/' + this._gene?.ensembl_gene_id + '/similar',
     ]);

src/app/features/genes/components/gene-search/gene-search.component.ts

@@ -157,6 +157,8 @@ export class GeneSearchComponent extends Unsub implements AfterViewInit {
     this.results = [];
     this.showGeneResults = false;
     this.searchNavigated.emit();
+    // https://github.com/angular/angular/issues/45202
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     this.router.navigate(['/genes/' + id]);
   }
 

src/app/features/genes/components/gene-similar/gene-similar.component.ts

@@ -72,6 +72,8 @@ export class GeneSimilarComponent implements OnInit {
           .subscribe((gene: Gene | null) => {
             if (!gene) {
               this.helperService.setLoading(false);
+              // https://github.com/angular/angular/issues/45202
+              // eslint-disable-next-line @typescript-eslint/no-floating-promises
               this.router.navigateByUrl('/404-not-found', { skipLocationChange: true });
             } else {
               this.gene = gene;
@@ -144,6 +146,8 @@ export class GeneSimilarComponent implements OnInit {
   navigateToGeneComparisonTool() {
     const ids: string[] = this.genes.map((g: Gene) => g.ensembl_gene_id);
     this.helperService.setGCTSelection(ids);
+    // https://github.com/angular/angular/issues/45202
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     this.router.navigate(['/genes/comparison']);
   }
 }

src/app/features/genes/components/gene-table/gene-table.component.ts

@@ -139,6 +139,8 @@ export class GeneTableComponent implements OnInit {
   }
 
   navigateToGene(gene: any) {
+    // https://github.com/angular/angular/issues/45202
+    // eslint-disable-next-line @typescript-eslint/no-floating-promises
     this.router.navigate(['/genes/' + gene.ensembl_gene_id]);
   }
 
@@ -174,12 +176,16 @@ export class GeneTableComponent implements OnInit {
 
   navigateToGeneComparisonTool() {
     if (typeof this.gctLink === 'object') {
+      // https://github.com/angular/angular/issues/45202
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       this.router.navigate(['/genes/comparison'], {
         queryParams: this.gctLink,
       });
     } else {
       const ids: string[] = this._genes.map((g: Gene) => g.ensembl_gene_id);
       this.helperService.setGCTSelection(ids);
+      // https://github.com/angular/angular/issues/45202
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
       this.router.navigate(['/genes/comparison']);
     }
   }