AG-1173 added TEP logic to gene hero #1229
Conversation
| it('should only add TEP text if nominations is null and either is_tep or is_adi is true', () => { | ||
| component.gene = geneMock3; | ||
| fixture.detectChanges(); | ||
|
|
||
| const el = element.querySelector('.gene-hero-nominated') as HTMLElement; | ||
|
|
||
| const expected = 'Selected for Target Enabling Resource Development'; | ||
| expect(el.textContent).toBe(expected); | ||
| }); |
There was a problem hiding this comment.
Nice tests! You could also consider adding tests to show that 1) only "Nominated Target" is shown when is_tep and is_adi are both false, and 2) nothing is displayed when nominations is null and both is_tep and is_adi are false. Up to you though!
There was a problem hiding this comment.
My latest commit should have these missing tests. thanks!
| is_tep: true | ||
| }; | ||
|
|
||
| export const geneMock3: Gene = { |
There was a problem hiding this comment.
From the build log, it looks like this mock might be missing nominatedtarget and nominations fields:
ERROR in src/app/testing/gene-mocks.ts:3153:14 - error TS2739: Type '{ _id: string; ensembl_gene_id: string; name: string;
summary: string; hgnc_symbol: string; alias: string[]; isIGAP: false; haseqtl: true; isAnyRNAChangedInADBrain: true;
rna_brain_change_studied: true; ... 5 more ...; is_tep: true; }' is missing the following properties from type 'Gene':
nominatedtarget, nominations
3153 export const geneMock3: Gene = {
~~~~~~~~~
There was a problem hiding this comment.
Looks like I didn't commit all my changes. Good catch!
Added border condition unit test as per @hallieswan |
No description provided.