AG-1472: push/pull data images from GHCR #1313
Conversation
| outputs: | ||
| DATA_MANIFEST_ID: ${{ steps.get-ids-from-package-json.outputs.DATA_MANIFEST_ID }} | ||
| DATA_VERSION: ${{ steps.get-ids-from-package-json.outputs.DATA_VERSION }} | ||
| DATA_IMAGE_PATH: ${{ steps.get-ids-from-package-json.outputs.DATA_IMAGE_PATH }} | ||
| IMAGE_EXISTS: ${{ steps.check-container-repo.outputs.IMAGE_EXISTS }} |
There was a problem hiding this comment.
Outputs will be used by subsequent jobs
| run: | | ||
| echo "==> data image tag: ${{ env.DATA_IMAGE_TAG }}" | ||
| echo "IMAGE_EXISTS=false" >> "$GITHUB_ENV" | ||
| GH_PATH=$( [[ "${{ env.NAMESPACE }}" == "${{ env.ORG_NAME }}" ]] && echo "${{ env.ORG_PATH }}" || echo "${{ env.USER_PATH }}" ) |
There was a problem hiding this comment.
If the job is running in the Sage-Bionetworks repo, then check for the image in the organization namespace using the ORG_PATH. Otherwise, check for the image in the user's namespace using the USER_PATH.
| build-image: | ||
| needs: check-for-image | ||
| if: ${{ needs.check-for-image.result == 'success' && needs.check-for-image.outputs.IMAGE_EXISTS == 'false' }} |
There was a problem hiding this comment.
The workflow will build the image if it does not already exist in the GHCR package, as in this run.
| # always() prevents skipping this job when build-image was skipped | ||
| # see https://github.com/actions/runner/issues/491 | ||
| if: ${{ always() && needs.check-for-image.result == 'success' && (needs.build-image.result == 'success' || needs.build-image.result == 'skipped')}} |
There was a problem hiding this comment.
The workflow will run the run-e2e-test job even if the image did not need to be built, as in this run.
| @@ -1,5 +1,9 @@ | |||
| FROM mongo:latest | |||
|
|
|||
| # GHCR labels | |||
| ARG SOURCE_REPO="https://github.com/Sage-Bionetworks/agora" | |||
There was a problem hiding this comment.
to make it more reusable for other repos consider using:
ARG SOURCE_REPO="https://github.com/${{ github.repository }}"
There was a problem hiding this comment.
Agreed on reusability! I've tried to do that by making SOURCE_REPO a build-time ARG, so it can be overwritten when the Docker image is built. The current value is a default that primarily demonstrates what SOURCE_REPO should look like.
In the GHA workflow, we override the value at build-time here, but I agree that using ${{ github.repository }} would be clearer, so I'll update to use that instead!
.github/workflows/e2e.yml
Outdated
| # TODO - push image to remote repository | ||
|
|
||
| # Note: if a new package is created using this workflow, then the package | ||
| # visibility will default to the source repository visbility. For example, |
There was a problem hiding this comment.
Thanks for the catch! I'll update in the next commit.
Will create a GHCR package called "agora-data" in the user's account (for forked repos) or in the Sage-Bionetworks organization (for the base repo). See example GHCR package in user account here.