automatically create new columns when the schema changes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private List<String> getColumnNameListForTable(String synapseTableId) throws SynapseException { | ||
| // Get columns from Synapse | ||
| // Helper method to detect when a schema changes and updates the Synapse table accordingly. Will reject schema | ||
| // changes that delete or modify columns. Optimized so if no columns were inserted, it won't modify the table. |
There was a problem hiding this comment.
What happens if it rejects a delete or a type change? The export fails, or is the export later put in a new table? It looks like it just skips those columns on export... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support mutable schemas. Bridge-EX will now compare the existing columns in a Synapse table against the column defs generated from a schema, and update the Synapse table accordingly if they are different. Has checks to prevent against column deletion and column modification. Allows column re-ordering. Optimized to not update tables if no columns are added.
This check and update is only run once per Exporter run.
Validation done:
Manual tests: