Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to make ScheduledActivity fields writable #501

Closed
wants to merge 1 commit into from
Closed

need to make ScheduledActivity fields writable #501

wants to merge 1 commit into from

Conversation

DwayneJengSage
Copy link
Collaborator

In Android, we need to marshall and unmarshall ScheduledActivity into SQL-Lite form. When we reconstituate these from database, we need to be able to set these fields.

alxdarksage
alxdarksage approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@alxdarksage alxdarksage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But see comment on Slack: how widespread a problem could this be once we start caching more generally? Maybe we shouldn't use this annotation at the cost of a more verbose API.

@alxdarksage
Copy link
Contributor

Josh isn't totally in agreement with this approach... let's think about all our alternatives before going down this path.

@DwayneJengSage
Copy link
Collaborator Author

We decided on an alternative. See email thread.

@DwayneJengSage DwayneJengSage deleted the dev-djeng3 branch July 18, 2018 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxdarksage alxdarksage alxdarksage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DwayneJengSage @alxdarksage